Update alacritty #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echo did not expand newline escape sequences for me, printf does this more reliable.
-o is not well defined and might not work on some systems.
The second check to update-alternatives on debian was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building Alacritty was failing for me, but comment alacritty/alacritty#128 (comment) had a working patch for me, so I updated the script to use the latest version and this patch instead.
As it was failing now at line 90 I added the missing var check to INSTALLDEPS too.
Additionally i made the script more robust by surrounding all vars with " and replacing some not widely supported functions.