Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #24

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix links #24

merged 1 commit into from
May 7, 2021

Conversation

ju-sh
Copy link
Contributor

@ju-sh ju-sh commented May 5, 2021

Fixed some links.

To do

Subreddit link

Subreddit link in community.md file is for old reddit. Can that be changed to the new version?

Gmane

The Gmane link is no longer working.

Seems it's not there now as mentioned in issues like this and this.

Maybe it should be removed? Unless an alternative can be found?

Hakyll

README.md still mentions Hakyll.

Does the site still use it after the move to jekyll? If not, maybe that can be removed as well?

@liskin
Copy link
Member

liskin commented May 5, 2021

The Gmane link is no longer working.

Seems it's not there now as mentioned in issues like this and this.

Maybe it should be removed? Unless an alternative can be found?

The pipermail archive is the best alternative we have I think.

@slotThe
Copy link
Member

slotThe commented May 5, 2021 via email

Copy link
Member

@slotThe slotThe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md still mentions Hakyll.

Does the site still use it after the move to jekyll? If not, maybe that can be removed as well?

I think we're only using Jekyll at this point, so that can probably be removed as well.

The rest of it looks good to me; thanks!

community.md Outdated Show resolved Hide resolved
documentation.md Outdated Show resolved Hide resolved
install-instructions.md Outdated Show resolved Hide resolved
@ju-sh
Copy link
Contributor Author

ju-sh commented May 6, 2021

And from what could be found from here, it looked as if Jekyll does not produce a _cache/ directory while caching output. If that's the case, maybe we can remove _cache/ from the .gitignore file?

I suppose the .jekyll-cache takes care of caching in Jekyll, but wasn't sure.

@TheMC47
Copy link
Member

TheMC47 commented May 6, 2021

And from what could be found from here, it looked as if Jekyll does not produce a _cache/ directory while caching output. If that's the case, maybe we can remove _cache/ from the .gitignore file?

I suppose the .jekyll-cache takes care of caching in Jekyll, but wasn't sure.

My bad, I forgot to update all the README after changing to jekyll. I'll check it later and update it, if you don't want to test it. I guess we just use the defaults, as GitHub takes care of the rest

@ju-sh
Copy link
Contributor Author

ju-sh commented May 6, 2021

@TheMC47 I was just nosing around.

Don't even know enough of Jekyll or anything to test it. :-D

You guys have done great work transiting the whole thing to Jekyll without breaking anything and we are enjoying the benefits.

I was just hoping to learn a thing or two about Jekyll in between while also trying to help :-)

@ju-sh ju-sh force-pushed the fix-wiki-links branch from bc3a770 to fc8d325 Compare May 6, 2021 07:51
@TheMC47
Copy link
Member

TheMC47 commented May 6, 2021

Any bit of help is greatly appreciated. Thanks a lot! We were hoping to encourage contributions since all people need to do is update markdown

@TheMC47
Copy link
Member

TheMC47 commented May 7, 2021

And from what could be found from here, it looked as if Jekyll does not produce a _cache/ directory while caching output. If that's the case, maybe we can remove _cache/ from the .gitignore file?

You're right about that, the _cache isn't needed in .gitignore, and jekyll builds to _site. These were leftovers from when I experimented with hakyll and forgot to clean things up

@ju-sh
Copy link
Contributor Author

ju-sh commented May 7, 2021

I'll go ahead and remove _cache/ from .gitignore then.

@ju-sh ju-sh force-pushed the fix-wiki-links branch from fc8d325 to 9e7fae8 Compare May 7, 2021 05:48
@TheMC47
Copy link
Member

TheMC47 commented May 7, 2021

This is awesome, thanks a lot! We have some good fist issues that you might want to check out here, some of them don't require any Haskell like xmonad/xmonad-contrib#160. I'd be happy to see a contribution there! 🎉

@TheMC47 TheMC47 merged commit e55a313 into xmonad:gh-pages May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants