Adding Jenkins #150

uvvpavel · 2023-09-21T15:16:44Z

No description provided.

…pdf doc fail for now

xluciano

Nice work! I like it is tidy and well commented. I have a few questions. The only important one is about parallelizing the tests.

xluciano · 2023-09-26T10:42:36Z

lib_xcore_math/src/bfp/bfp_s16.c

@@ -339,12 +339,10 @@ float bfp_s16_mean(
    headroom_t hr = HR_S32(sum) + 32;
    int64_t sum64 = ((int64_t)sum) << hr;
    int64_t mean64 = sum64 / ((int)b->length);
-    right_shift_t shr = MAX(0, 48 - HR_S64(mean64));
+    right_shift_t shr = MAX(0, 32 - HR_S64(mean64));


I suppose this was the bug you found, well done!

This was not a bug but, it's resolving a TODO from below.

xluciano · 2023-09-26T10:43:18Z

lib_xcore_math/src/bfp/bfp_s16.c

    if(shr > 0) 
-        mean64 += 1 << (shr-1);


can you add a comment to explain why you have to cast a uint32_t value into uint64_t?

I did a slight update on this line. I don't really know how to comment it, as it's a standard procedure for rounding

xluciano · 2023-09-26T10:43:39Z

lib_xcore_math/src/bfp/bfp_s32.c

@@ -335,8 +335,8 @@ float_s32_t bfp_s32_mean(
    right_shift_t shr = MAX(0, 32 - HR_S64(mean));

    if(shr > 0)
-        mean += 1 << (shr-1);
-
+        mean += (uint32_t)(1 << (shr-1));


can you add a comment to explain why you have to cast a uint32_t value into uint64_t?

I did a slight update on this line. I don't really know how to comment it, as it's a standard procedure for rounding

test/dct_tests/src/test_dctXX_inverse.c

xluciano · 2023-09-26T10:48:02Z

Jenkinsfile

+              steps {
+                dir('lib_xcore_math/build_xs3a/test') {
+                  withTools(params.TOOLS_VERSION) {
+                    sh 'xrun --xscope --id 0 --args bfp_tests/bfp_tests.xe        -v'


what does "-v" option do? Doesn't it just print the version? If you want to increase the verbosity, you need to use "--verbose", but I never used it myself,

-v here is for the test itself, not xrun, hence it has --args. It means verbose

xluciano · 2023-09-26T10:50:00Z

test/dct_tests/src/test_dctXX_inverse.c

 #define MAX_PROC_FRAME_LENGTH_LOG2 9
 #define MAX_PROC_FRAME_LENGTH (1<<MAX_PROC_FRAME_LENGTH_LOG2)

 #define MIN_DCT_N_LOG2  (3)
 #define LOOPS_LOG2  (0)


-


why is SMOKE_TEST not used here? Is it because LOOPS_LOG2 is already 0?

Yes, we can't go any lower

xluciano · 2023-09-26T10:52:14Z

Jenkinsfile

+      description: 'The XTC tools version'
+    )
+    booleanParam(
+      name: 'XMATH_SMOKE_TEST',


how long the tests last if XMATH_SMOKE_TEST is set to False? I wonder we should use it by default if they last less than 30 min. If we decide to run the tests in smoke test mode, when do we run the full tests?

xluciano · 2023-09-26T10:54:40Z

Jenkinsfile

+  stages {
+    stage('Bullds and tests') {
+      parallel {
+        stage('Linux builds and tests') {


why don't we parallelize the xs3 tests with the x86 ones? We will reduce the duration of the Jenkins run by a considerable amount.

The way it's designed right now is that the smoke run takes 4 min, and the non-smoke run takes 30 min. This whole stage is executed on a single agent. It's not gonna bring much benefit for a smoke run. and will reduce a non-smoke run by 4 min as xs3 takes 27 min and x86 takes 4 min.

Thanks for the explanation and the details

xluciano

One more comment.

test/dct_tests/src/test_dctXX_inverse.c

xluciano

Looks good!

xluciano

The Jenkins artifacts contain the build files for the documentation. They shouldn't be archived.
See http://srv-bri-jcim0:8080/blue/organizations/jenkins/XMOS%2Flib_xcore_math/detail/PR-150/18/artifacts

Jenkinsfile

BrennanGit · 2023-09-26T11:23:45Z

Jenkinsfile

+  options {
+    skipDefaultCheckout()
+    timestamps()
+    buildDiscarder(xmosDiscardBuildSettings())


I should note here that this will modify build deletion settings going forward.
details: https://github.com/xmos/xmos_jenkins_shared_library/pull/331

BrennanGit · 2023-09-27T09:00:35Z

The Jenkins artifacts contain the build files for the documentation. They shouldn't be archived. See http://srv-bri-jcim0:8080/blue/organizations/jenkins/XMOS%2Flib_xcore_math/detail/PR-150/18/artifacts

This is basically because the docs build "fails". That means it bombs out before the cleanup of build files. I hope to fix this in the v4 modification.

uvvpavel · 2023-09-27T09:10:26Z

The Jenkins artifacts contain the build files for the documentation. They shouldn't be archived. See http://srv-bri-jcim0:8080/blue/organizations/jenkins/XMOS%2Flib_xcore_math/detail/PR-150/18/artifacts

This is basically because the docs build "fails". That means it bombs out before the cleanup of build files. I hope to fix this in the v4 modification.

@lucianomartin I'll leave it there for now as it's being archived with the rest of the docs.

xluciano

All good. The doc build artifacts will be removed in a future PR.

BrennanGit

Jenkins stuff looks good to me 👍

uvvpavel added 13 commits September 21, 2023 16:16

adding initial jenkinsfile

0a4ce09

fixing doc build

1fd80bf

fixing paths

314cb68

adding legacy build, making sure xs3a test do actually run, ignoring …

f1cb65f

…pdf doc fail for now

fixing jenkins

7b354d7

adding --id 0

e4f83cc

fixing vect_s16_prepare API documentation

19a0e91

shorteting the smoke run

21de6db

reverting idct loop_log change

c46b89b

removing github actions and codeowners, updating changelog

e93874c

using correct env varioable for a smoke test

1ae8751

actually using smoke test variable now

c9d8d79

fixing bfp_mean test, adding xsa tests to x86 testing

e7ce2ca

uvvpavel requested review from BrennanGit and xluciano September 26, 2023 10:35

xluciano reviewed Sep 26, 2023

View reviewed changes

test/dct_tests/src/test_dctXX_inverse.c Show resolved Hide resolved

more correct typecasting

8470bd3

uvvpavel requested a review from xluciano September 26, 2023 12:23

xluciano approved these changes Sep 26, 2023

View reviewed changes

xluciano suggested changes Sep 27, 2023

View reviewed changes

BrennanGit requested changes Sep 27, 2023

View reviewed changes

review changes

32a46a6

xluciano approved these changes Sep 27, 2023

View reviewed changes

uvvpavel requested a review from BrennanGit September 27, 2023 09:14

noe more proper cleanup

d835422

BrennanGit approved these changes Sep 27, 2023

View reviewed changes

uvvpavel merged commit bdea3cf into xmos:develop Sep 27, 2023
1 check passed

uvvpavel deleted the feature/jenkins branch September 27, 2023 09:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Jenkins #150

Adding Jenkins #150

uvvpavel commented Sep 21, 2023

xluciano left a comment

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023 •

edited

Loading

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023

xluciano Sep 26, 2023

xluciano Sep 26, 2023

uvvpavel Sep 26, 2023

xluciano Sep 26, 2023

xluciano left a comment

xluciano left a comment

xluciano left a comment

BrennanGit Sep 26, 2023

BrennanGit commented Sep 27, 2023

uvvpavel commented Sep 27, 2023

xluciano left a comment

BrennanGit left a comment

Adding Jenkins #150

Adding Jenkins #150

Conversation

uvvpavel commented Sep 21, 2023

xluciano left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uvvpavel Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xluciano left a comment

Choose a reason for hiding this comment

xluciano left a comment

Choose a reason for hiding this comment

xluciano left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrennanGit commented Sep 27, 2023

uvvpavel commented Sep 27, 2023

xluciano left a comment

Choose a reason for hiding this comment

BrennanGit left a comment

Choose a reason for hiding this comment

uvvpavel Sep 26, 2023 •

edited

Loading