-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor NVML + Health bits #256
base: dev
Are you sure you want to change the base?
Conversation
I will merge it today evening or tomorrow, need some time for it, because I support fully functional command line interface, adding new options not that simple. |
I can add that too, I just didn't. Thought it would be safer to have it harder to edit? |
and mainly 45-65 is not my favorite range so I made it compile-time feature first really just remove the configuration part, I don't want it there hardcoded only. |
I only added it into the threads tree since that's the only place to store them per-GPU I just never saw those colors change and wondered if the range was right, if they would... :) |
The best part is I run everything through meta-miner so it strips off any color anyways so I literally don't see it |
I get multiple issues:
I decided reject this PR in current state, but I agree with you, temperatures should be configurable, probably better names for options is |
Also:
|
630c485
to
3554f92
Compare
Applied much of the cool stuff onto #257 and then some definitely need to test on Linux too or I'm going to keep bashing into silly problems Could have sworn |
c9ce58a
to
d9b3aa3
Compare
…play color thresholds configurable both compile-time and runtime
Allow unavailable items to disappear
Make thermal display color thresholds configurable
src/defaults.h
temp_low
andtemp_high
within advanced thread configand random patches to anything that stuck out while I was in the area(s) half of which my editor just does for me anyways (actually harder to NOT do them)