XIP-21: Incorporate suggestion from Aurel/Chain Agnostic Initiative #55
+5
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurelticot
reviewed
Apr 13, 2024
| */ | ||
| namespace?: string; | ||
| chainId?: string; | ||
| /** | ||
| * The networkId for the transaction, in decimal or hexidecimal format | ||
| */ | ||
| networkId: number | string; |
There was a problem hiding this comment.
The networkId is no longer necessary as it's the <reference> part of the chainId.
There was a problem hiding this comment.
So wonderful to see you here @aurelticot - thank you for your partnership on this! 🤝
cc'ing @neekolas for help with confirming this change to the XIP spec. 🫡
There was a problem hiding this comment.
Fixed to remove networkId. My oversight! Thank you.
neekolas
approved these changes
Apr 16, 2024
aurelticot
reviewed
Apr 18, 2024
aurelticot
reviewed
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.xmtp.org/t/xip-21-on-chain-transaction-reference-content-type/532/2?u=jha