review

dev/test-wasm-interactive

@@ -15,7 +15,7 @@ WASM_BINDGEN_SPLIT_LINKED_MODULES=1 \
   WASM_BINDGEN_TEST_ONLY_WEB=1 \
   NO_HEADLESS=1 \
   cargo test --target wasm32-unknown-unknown --release \
-  -p $PACKAGE -- subscriptions:: \
+  -p $PACKAGE -- \
   --skip xmtp_mls::storage::encrypted_store::group_message::tests::it_cannot_insert_message_without_group \
   --skip xmtp_mls::groups::tests::process_messages_abort_on_retryable_error \
   --skip  xmtp_mls::storage::encrypted_store::group::tests::test_find_groups \

xmtp_api_http/src/http_stream.rs

@@ -238,7 +238,6 @@ where
         // It should always be pending
         let noop_waker = futures::task::noop_waker();
         let mut cx = std::task::Context::from_waker(&noop_waker);
-        // let mut this = Pin::new(self);
         let mut this = Pin::new(self);
         if this.poll_next_unpin(&mut cx).is_ready() {
             tracing::error!("Stream ready before established");

xmtp_mls/src/subscriptions/stream_conversations.rs

@@ -352,7 +352,6 @@ where
                         .conversation_type
                         .map_or(true, |ct| ct == metadata.conversation_type)
                         .then_some((group, id)));
-                    // Ok(Some(self.load_from_store(id).map(|(g, v)| (g, Some(v)))?));
                 }
 
                 let (group, id) = self.on_welcome(welcome).await?;

xmtp_mls/src/subscriptions/stream_messages.rs

@@ -484,7 +484,6 @@ where
     }
 
     /// Checks if a message has already been processed through a sync
-    // TODO: Make this not async, and instead of retry add it back to wake queue.
     fn needs_to_sync(&self, current_msg_cursor: u64) -> Result<bool> {
         let check_for_last_cursor = || -> std::result::Result<i64, StorageError> {
             self.provider