Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error out when there is no receiver #1375

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

codabrink
Copy link
Contributor

@codabrink codabrink commented Dec 4, 2024

It's possible that there is no receiver for this broadcast, so we do not want to propagate errors from broadcast sends.

xmtp/xmtp-android#340

@codabrink codabrink requested a review from a team as a code owner December 4, 2024 19:40
@codabrink codabrink linked an issue Dec 4, 2024 that may be closed by this pull request
@codabrink codabrink enabled auto-merge (squash) December 4, 2024 19:43
@codabrink codabrink merged commit 76114b2 into main Dec 4, 2024
10 checks passed
@codabrink codabrink deleted the coda/lossy-events branch December 4, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group error: generic: channel closed
3 participants