Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not validate dm mutable metadata permissions #1577

Merged
merged 3 commits into from
Feb 1, 2025
+17 −5
Merged

do not validate dm mutable metadata permissions #1577

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d0d3d1
do not validate dm mutable metadata permissions
cameronvoell Feb 1, 2025
ddc4d41
fmt fix
cameronvoell Feb 1, 2025
0eb1911
make test more lenient for wasm
cameronvoell Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions xmtp_mls/src/groups/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1836,9 +1836,17 @@ fn validate_dm_group(
));
}

// Validate permissions
// Validate permissions so no one adds us to a dm that they can unexpectedly add another member to
// Note: we don't validate mutable metadata permissions, because they don't affect group membership
let permissions = extract_group_permissions(mls_group)?;
if permissions != GroupMutablePermissions::new(PolicySet::new_dm()) {
let expected_permissions = GroupMutablePermissions::new(PolicySet::new_dm());

if permissions.policies.add_member_policy != expected_permissions.policies.add_member_policy
&& permissions.policies.remove_member_policy != expected_permissions.policies.remove_member_policy
&& permissions.policies.add_admin_policy != expected_permissions.policies.add_admin_policy
&& permissions.policies.remove_admin_policy != expected_permissions.policies.remove_admin_policy
&& permissions.policies.update_permissions_policy != expected_permissions.policies.update_permissions_policy
{
return Err(GroupError::Generic(
"Invalid permissions for DM group".to_string(),
));
Expand Down
Loading