Signed ECIES Payloads #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakajima
approved these changes
Oct 4, 2023
|
@neekolas this is for the v2 portable preferences right? Does this belong in |
|
You would think so, but libxmtp only looks at the v3 branch. Including in libxmtp's V2 branch. We could change that, since it's quite confusing. |
|
Ahhh gotcha. Fine with leaving it as-is for now |
|
Really what I'd like to do is kill the v3 proto branch. None of our v3 work to date has involved changing any v2 protos, and I don't think it will. So the separate branching strategy isn't protecting us from much. |
|
🎉 This PR is included in version 3.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SignedPayloadmessage type to hold arbitrary bytes and a signatureEciesMessage, which currently just holds av1structure for encryptedSignedPayloadmessages