Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the appropriate files so that they get generated #108

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

nplasterer
Copy link
Contributor

I wasn't seeing the new proto files in the latest kotlin release because we didn't tell them to generate. This should fix that.

@nplasterer nplasterer requested a review from neekolas October 24, 2023 19:12
@nplasterer nplasterer self-assigned this Oct 24, 2023
@nplasterer nplasterer requested a review from a team as a code owner October 24, 2023 19:12
@nplasterer
Copy link
Contributor Author

nplasterer commented Oct 24, 2023

We commit the swift stuff in this repo so you can use spm to access them. But because of cocoapods we actually just copy these files into the swift repo now. But if other integrators use spm directly to proto this change is useful

@nplasterer nplasterer merged commit 03f125c into main Oct 24, 2023
8 checks passed
@nplasterer nplasterer deleted the np/update-kotlin-generate branch October 24, 2023 19:31
@github-actions
Copy link

🎉 This PR is included in version 3.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants