Skip to content

Add WelcomeEncryption parameters to proto #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neekolas
Copy link
Collaborator

@neekolas neekolas commented Apr 9, 2025

TL;DR

Added support for specifying post-quantum cryptography in MLS welcome messages.

What changed?

  • Created a new encryption.proto file with a WelcomeEncryption enum that defines encryption types including post-quantum XWING_MLKEM_512
  • Added the encryption ciphersuite field to welcome messages in the MLS API
  • Updated the database intents to include encryption type information for installations

How to test?

  1. Verify that the new WelcomeEncryption enum is properly defined with the expected values
  2. Check that the welcome message structures correctly include the new ciphersuite field
  3. Ensure that installation records in the database can properly store the encryption type

Why make this change?

This change prepares the MLS protocol implementation for post-quantum cryptography support, specifically adding the ability to specify MLKEM-512 as an encryption algorithm for welcome messages. This enhances security by providing quantum-resistant encryption options alongside traditional curve25519.

Copy link
Collaborator Author

neekolas commented Apr 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

macroscopeapp bot commented Apr 9, 2025

Add WelcomeEncryption parameters to MLS protocol messages to support CURVE25519 and XWING_MLKEM_512 encryption algorithms

  • Adds new WelcomeEncryption enum in encryption.proto defining CURVE25519 and XWING_MLKEM_512 encryption types
  • Extends WelcomeMessage.V1 and WelcomeMessageInput.V1 in mls.proto with ciphersuite field
  • Adds encryption_type field to PostCommitAction.Installation in intents.proto

📍Where to Start

Start with the new enum definitions in encryption.proto which defines the core encryption types used by the other modified files.


Macroscope summarized 516d0ca. (Automatic summaries will resume when PR exits draft mode or review begins).

@neekolas neekolas force-pushed the 04-08-add_welcomeencryption_parameters_to_proto branch from 516d0ca to a5e6445 Compare April 16, 2025 16:22
@neekolas neekolas force-pushed the 04-08-add_welcomeencryption_parameters_to_proto branch from a5e6445 to cd57428 Compare April 16, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant