Surface streaming errors to be caught #243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
May 13, 2024
| break | ||
| } | ||
| } catch (error: Exception) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
@rsappelit is this kind of what you had in mind? Instead of catching these StatusExceptions just let them be thrown so you can catch and handle them?
neekolas
reviewed
May 13, 2024
| @@ -745,14 +737,6 @@ data class Conversations( | |||
| } | |||
| } catch (error: CancellationException) { | |||
| break | |||
| } catch (error: StatusException) { | |||
There was a problem hiding this comment.
Shouldn't we be trying to reconnect when these errors happen. If we throw we leave it up to the app to handle reconnects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233