Disappearing messages #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Feb 4, 2025
mchenani
reviewed
Feb 4, 2025
nplasterer
commented
Feb 5, 2025
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
nplasterer
commented
Feb 7, 2025
library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt
Outdated
Show resolved
Hide resolved
…isappearing-messages
nplasterer
commented
Feb 10, 2025
| assertEquals( | ||
| boDm.messages().size, | ||
| 2 | ||
| ) // disappearing settings 1, disappearing settings 2, boMessage, alixMessage |
There was a problem hiding this comment.
All these counts will need to be updated once we start showing group update messages in the dms. @mchenani
mchenani
approved these changes
Feb 10, 2025
library/src/main/java/org/xmtp/android/library/libxmtp/DisappearingMessageSettings.kt
Outdated
Show resolved
Hide resolved
cameronvoell
approved these changes
Feb 11, 2025
* add a delicate api warning level * slightly update the logic * Update library/src/main/java/org/xmtp/android/library/Client.kt Co-authored-by: Nicholas Molnar <[email protected]> * add a test for this case * fix lint --------- Co-authored-by: Nicholas Molnar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to update, set, and get expiration settings for messages on a DM or Group.