Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #240

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Improve error messages #240

merged 3 commits into from
Feb 6, 2024

Conversation

nakajima
Copy link
Contributor

@nakajima nakajima commented Feb 6, 2024

Should help out with xmtp/xmtp-react-native#225.

Closes #221.

Before:

XMTPiOS.ConversationError error 2

After:

Recipient cannot be sender

@nakajima nakajima requested a review from a team as a code owner February 6, 2024 21:58
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the podspec.

@nakajima nakajima merged commit a32ddac into main Feb 6, 2024
1 check passed
@nakajima nakajima deleted the improve-errors branch February 6, 2024 22:34
@cameronvoell cameronvoell restored the improve-errors branch February 9, 2024 03:05
kele-leanes pushed a commit that referenced this pull request Feb 19, 2024
* let errors be more descriptive

* remove test

* bump the podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Bubble up specific API error codes to the application developer
2 participants