Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing messages #466

Merged
merged 10 commits into from
Feb 12, 2025
Merged

Disappearing messages #466

merged 10 commits into from
Feb 12, 2025

Conversation

nplasterer
Copy link
Contributor

Adds the ability to set, update, and get disappearing message settings.

@nplasterer nplasterer self-assigned this Feb 10, 2025
@nplasterer nplasterer marked this pull request as ready for review February 11, 2025 01:41
@nplasterer nplasterer requested a review from a team as a code owner February 11, 2025 01:41

public struct DisappearingMessageSettings {
public let disappearStartingAtNs: Int64
public let disappearDurationInNs: Int64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on var naming, otherwise LGTM!

@nplasterer nplasterer merged commit b00d656 into main Feb 12, 2025
1 of 2 checks passed
@nplasterer nplasterer deleted the np/disappearing-messages branch February 12, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants