Merge pull request #610 from xmtp/ar/new-conversation-priorities

fix: update priority in newConversation method

.changeset/breezy-trains-fetch.md

@@ -0,0 +1,5 @@
+---
+"@xmtp/xmtp-js": patch
+---
+
+Updated priorities on newConversation method

packages/js-sdk/src/conversations/Conversations.ts

@@ -477,6 +477,18 @@ export default class Conversations<ContentTypes = any> {
     context?: InvitationContext,
     consentProof?: invitation.ConsentProofPayload
   ): Promise<Conversation<ContentTypes>> {
+    // Define a function for matching V2 conversations
+    const matcherFn = (convo: Conversation<ContentTypes>) =>
+      convo.peerAddress.toLowerCase() === peerAddress.toLowerCase() &&
+      isMatchingContext(context, convo.context ?? undefined)
+
+    // Check if we already have a V2 conversation with the peer in keystore
+    const existing = await this.getV2ConversationsFromKeystore()
+    const existingMatch = existing.find(matcherFn)
+    if (existingMatch) {
+      return existingMatch
+    }
+
     let contact = await this.client.getUserContact(peerAddress)
     if (!contact) {
       throw new Error(`Recipient ${peerAddress} is not on the XMTP network`)
@@ -521,17 +533,6 @@ export default class Conversations<ContentTypes = any> {
       contact = SignedPublicKeyBundle.fromLegacyBundle(contact)
     }
 
-    // Define a function for matching V2 conversations
-    const matcherFn = (convo: Conversation<ContentTypes>) =>
-      convo.peerAddress.toLowerCase() === peerAddress.toLowerCase() &&
-      isMatchingContext(context, convo.context ?? undefined)
-
-    const existing = await this.getV2ConversationsFromKeystore()
-    const existingMatch = existing.find(matcherFn)
-    if (existingMatch) {
-      return existingMatch
-    }
-
     return this.v2JobRunner.run(async (lastRun) => {
       const newItems = await this.updateV2Conversations(lastRun)
       const newItemMatch = newItems.find(matcherFn)