-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable api client #440
Merged
Merged
Pluggable api client #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
Latest commit: |
e9dc1d3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8f42d3d6.xmtp-js.pages.dev |
Branch Preview URL: | https://nmolnar-pluggable-api-client.xmtp-js.pages.dev |
…es from ApiClient
BREAKING CHANGE: changes return type of subscribe API
mkobetic
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like nice clean up.
🎉 This PR is included in version 11.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ApiClient
to allow for alternative implementationsApiClient
creation process with their own implementationApiClient
implementationApiClient
instead of handling in the applicationsubscribe
method, to support future changes which will allow updating content topics without closing the streamSolves
#438
Notes
Bit of backstory on the base64 decoding. The code generator for GRPC gateway is inconsistent with the envelope type. When sending a message, you can provide the
message
field as a Uint8Array. But when receiving messages, it returns that field as a base64 encoded string. In order to provide a consistent API that matches the new type definition, we need to consolidate that logic in theHttpApiClient
. This also just feels tidier.This is a breaking change and will go into the next major SDK release