Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap Support #446

Merged
merged 91 commits into from
Aug 30, 2023
Merged

Snap Support #446

merged 91 commits into from
Aug 30, 2023

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 29, 2023 •
edited
Loading

Summary

  • Exports request and response types for the Keystore API to generate the handlers inside the Snap
  • Changes return type of getV2Conversations from an array of objects to GetConversationsResponse to conform with the standard request/response handlers in the Snap
  • Adds (but does not yet enable) the new SnapKeystoreProvider
  • Adds feature-detection for the Metamask Snap so that we know whether or not Snaps are available when we start the SDK.
  • Adds types to window.ethereum

nakajima and others added 30 commits May 22, 2023 13:03
@nakajima
feat: begin adding some group conversation features
eeb9f2d
@nakajima
Use metadata instead of group context, remove redundant fields
25edc2e
@nakajima
Remove shared wallet
03022c1
@nakajima
cleanup
a46043f
@nakajima
Add super basic test
8b39ad8
@nakajima
unlink proto npm
e10adaa
@nakajima
Make sure we're not mutating when we don't wanna
39d452a
@nakajima
Update test to reflect group-ness being part of the conversation ID
6cc1dc1
@nakajima
Don't consider empty initialMembers as a group
ad6d582
@nakajima
use local we already have
0061e3d
@nakajima
Simplify API for creating a new group convo
6869df9
@nakajima
Merge branch 'beta' into multi-invites
f632e70
@nakajima
Make sure creator address is in initial members and dedup
748720e
@nakajima
Merge branch 'multi-invites' of https://github.com/xmtp/xmtp-js into …
c0fb9af 
…multi-invites
@nakajima
Avoid self dh
1746cca
@nakajima
Introduce group content types
8ba9854
@nakajima
Add a test for adding members
513c7ec
@nakajima
Add additional assertion to make sure member adding actually works
8855108
@nakajima
Update authority id
6f5d860
@nakajima
remove unnecessary wrapper around newGroupConversation
0805413
@nakajima
punt on nicknames
2fc86b9
@nakajima
fix: no need for this change
1bb882f
@nakajima
fix: no need for this change
9884c6f
@nakajima
fix: crypto import
2a6229d
@nakajima
fix: crypto import
e2503ff
@nakajima
feat: introduce dedicated group chat invitation topic
6903495
@nakajima
fix: topic prefixes can't have dashes
94e9c2d
@nakajima @neekolas
Update src/conversations/Conversations.ts
786f8e6 
Co-authored-by: Nicholas Molnar <[email protected]>
@nakajima
Merge branch 'multi-invites' into group-content-types
52e83e5
@nakajima
fix: add runtime validation
6a29c2d
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 29, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7f318b1
Status: ✅  Deploy successful!
Preview URL: https://98bf3c4b.xmtp-js.pages.dev
Branch Preview URL: https://nmolnar-merge-beta-to-snap.xmtp-js.pages.dev

View logs

@neekolas neekolas changed the title Nmolnar/merge beta to snap Snap Support Aug 30, 2023
@neekolas neekolas marked this pull request as ready for review August 30, 2023 15:49
@neekolas neekolas requested review from a team, mkobetic and rygine and removed request for a team August 30, 2023 15:49
rygine
rygine reviewed Aug 30, 2023
View reviewed changes
src/codecs/TypingNotification.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@neekolas neekolas merged commit 085da5c into beta Aug 30, 2023
7 checks passed
@neekolas neekolas deleted the nmolnar/merge-beta-to-snap branch August 30, 2023 23:00
@neekolas neekolas mentioned this pull request Aug 30, 2023
Closed
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rygine rygine rygine left review comments

@mkobetic mkobetic Awaiting requested review from mkobetic

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neekolas @rygine @nakajima