Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI workflows #633

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Optimize CI workflows #633

merged 1 commit into from
Jun 15, 2024

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jun 15, 2024

Summary

Since the JS SDK and the MLS Client are separate packages, only run their respective workflows when their files change.

This PR also upgrades to Warp runners where possible. For some reason, there are fetch issues in some of the JS SDK tests on Warp runners so will use GitHub runners for testing.

@rygine rygine requested a review from a team June 15, 2024 15:33
Copy link

changeset-bot bot commented Jun 15, 2024

⚠️ No Changeset found

Latest commit: b86960a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rygine rygine force-pushed the rygine/optimize-workflows branch from faaea85 to e625194 Compare June 15, 2024 15:34
Copy link

cloudflare-workers-and-pages bot commented Jun 15, 2024

Deploying xmtp-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b86960a
Status: ✅  Deploy successful!
Preview URL: https://c90adb09.xmtp-js.pages.dev
Branch Preview URL: https://rygine-optimize-workflows.xmtp-js.pages.dev

View logs

@rygine rygine force-pushed the rygine/optimize-workflows branch from e625194 to b86960a Compare June 15, 2024 15:34
- main

pull_request:
paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know this option was a thing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm using this for the node bindings in libxmtp as well. i have some more optimizations in mind for libxmtp to help speed up the workflows using paths.

@rygine rygine merged commit a77ef56 into main Jun 15, 2024
11 of 13 checks passed
@rygine rygine deleted the rygine/optimize-workflows branch June 15, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants