Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonce JSON-RPC endpoint #72

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Add nonce JSON-RPC endpoint #72

merged 4 commits into from
Feb 22, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 21, 2024

Adds a nonce endpoint in order to sign setAttribute payloads in libxmtp and xps-cli

  • adds documentation for walletAddress
  • fixes docs in some places
  • adds nonce endpoint & tests
  • tests for resolve_did_address

closes #63

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65634b5) 76.43% compared to head (39105d8) 78.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   76.43%   78.75%   +2.31%     
==========================================
  Files          13       14       +1     
  Lines         522      579      +57     
==========================================
+ Hits          399      456      +57     
  Misses        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx insipx requested review from jac18281828, 37ng and tsachiherman and removed request for jac18281828 February 21, 2024 22:02
Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
not in the scope of this pr - I think our doc could be more concise and omit information that could be found in JSON-RPC 2.0 Specification

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thanks for adding this

lib-xps/src/rpc/api.rs Show resolved Hide resolved
lib-xps/src/rpc/api.rs Outdated Show resolved Hide resolved
@insipx insipx merged commit e04ae49 into main Feb 22, 2024
8 checks passed
@insipx insipx deleted the nonce-rpc branch February 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature request: Add RPC endpoint for retrieving the nonce from the DIDRegistry smart contract
3 participants