Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java11 #26

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Java11 #26

merged 1 commit into from
Jan 5, 2024

Conversation

ehsavoie
Copy link
Contributor

@ehsavoie ehsavoie commented Nov 16, 2023 •
edited
Loading

  • Using ByteBufferPool instead of ByteBufferSlicePool.
  • Creating a profile for Java > 8 with BC as a dependency for certificate creation and an updated version of jboss logging.

@ehsavoie
Copy link
Contributor Author

ehsavoie commented Jan 4, 2024

@fl4via @dmlloyd could you take a look at my change from ByteBufferSlicePool to ByteBufferPool as it seems to 'fix' the Java 11 issue

@ehsavoie ehsavoie requested a review from dmlloyd January 4, 2024 15:22
dmlloyd
dmlloyd reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me, other than some minor comments on the POM changes.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@ehsavoie
Copy link
Contributor Author

ehsavoie commented Jan 4, 2024 •
edited
Loading

@dmlloyd the strange part is that I can't build on java 8 anymore is ByteBufferPool Java > 8 only ?
Sorry it is the jboss logging version

@ehsavoie ehsavoie force-pushed the java11 branch 3 times, most recently from dd64f93 to fef7348 Compare January 4, 2024 17:25
@ehsavoie ehsavoie marked this pull request as ready for review January 4, 2024 17:26
@ehsavoie ehsavoie force-pushed the java11 branch 3 times, most recently from a63ea4a to 3ff5e0b Compare January 4, 2024 17:33
ropalka
ropalka approved these changes Jan 4, 2024
View reviewed changes
Copy link

@ropalka ropalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully verified it with JDK11, JDK17 & JDK21

dmlloyd
dmlloyd reviewed Jan 4, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@ehsavoie
Updating to support Java 11
a8f0e11 
 * Using ByteBufferPool instead of ByteBufferSlicePool.
 * Creating a profile for Java > 8 with BC as a dependency for
   certificate creation and an updated version of jboss logging.

Signed-off-by: Emmanuel Hugonnet <[email protected]>
@ehsavoie ehsavoie merged commit 289e1c2 into xnio:main Jan 5, 2024
2 checks passed
@ehsavoie ehsavoie deleted the java11 branch January 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd left review comments

@ropalka ropalka ropalka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsavoie @dmlloyd @ropalka