Update README.md #38
Merged
Update README.md #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into some problems installing xroms with the directions in the README.md. It turns out that Github updated their security protocols a while back and so the installation guide needs to be updated. I made some very minor changes to the README.md in order for the installation be successful using the given instructions.
navidcy
approved these changes
Jun 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 17 17
Lines 1898 1898
=======================================
Hits 1593 1593
Misses 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you @najascutellatus and @navidcy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some problems installing xroms with the directions in the README.md. It turns out that Github updated their security protocols a while back and so the installation guide needs to be updated. I made some very minor changes to the README.md in order for the installation be successful using the given instructions.