Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supabase-csharp #428

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add supabase-csharp #428

wants to merge 12 commits into from

Conversation

tk-aria
Copy link
Contributor

@tk-aria tk-aria commented Nov 28, 2024

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package:
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@bdovaz
Copy link
Collaborator

bdovaz commented Dec 4, 2024

@tk-aria you suggest a deprecated package when it has its alternative on that same page: https://www.nuget.org/packages/Supabase/

The only thing I see is that the alternative only targets .netstandard2.1: https://github.com/supabase-community/supabase-csharp/blob/master/Supabase/Supabase.csproj

You should suggest an issue/PR to support .netstandard2.0 as well.

@tk-aria
Copy link
Contributor Author

tk-aria commented Dec 6, 2024

@bdovaz
Thank you for confirming. You're right; I indeed overlooked this.

I wanted to make the old package compatible with UPM, so I worked on the older version. However, upon checking the following, it seems that support for .NET Standard 2.0 is only up to version 1.0.5:
https://www.nuget.org/packages/Supabase/1.0.5

You should suggest an issue/PR to support .netstandard2.0 as well.

What does this mean?

@bdovaz
Copy link
Collaborator

bdovaz commented Dec 6, 2024

Ok, I didn't realize that at least up to version 1.0.5 it is netstandard2.0 compatible.

Unity is not netstandard2.1 compatible until Unity 2021.x and this repository tries to maintain 2.0 compatibility where possible.

What I would do is have this PR try to add the package which is not deprecated and Unity 2021 users backwards can at least use up to version 1.0.5 of this package.

@tk-aria
Copy link
Contributor Author

tk-aria commented Dec 9, 2024

Ok, I didn't realize that at least up to version 1.0.5 it is netstandard2.0 compatible.

Unity is not netstandard2.1 compatible until Unity 2021.x and this repository tries to maintain 2.0 compatibility where possible.

What I would do is have this PR try to add the package which is not deprecated and Unity 2021 users backwards can at least use up to version 1.0.5 of this package.

Ok. I will fix it.

@bdovaz
Copy link
Collaborator

bdovaz commented Dec 10, 2024

@tk-aria but what I am saying is to ONLY add the package that is not deprecated, actually you are adding both

@tk-aria
Copy link
Contributor Author

tk-aria commented Dec 12, 2024

@tk-aria but what I am saying is to ONLY add the package that is not deprecated, actually you are adding both

@bdovaz
For older applications, there may be cases where we want to use an older version, so we would like to proceed with a flow that accommodates both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants