TestCaseSource on RegistryTests

[Thaina]

This is not request for registry but propose change on the RegistryTests so each registry entry would be tested separately for each case and have explicit case entry for easier investigating and rerun

[bdovaz]

@Thaina please merge master in your branch

[Thaina]

Already merged

Do you think are there any concern about change test like this?
Such as, I have remove Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions which only do Assert.Inconclusive into Warn.If

[bdovaz]

Let me check it this week and let you know.

The test you mention is to know which packages have more versions because there are some like AWS that makes daily builds and if we don't raise the minimum version in the registry.json file from time to time, it ends up growing infinitely causing disk space or processing/initialization time problems.

[bdovaz]

Can you resolve the conflicts? Thanks!

[Thaina]

@bdovaz resolved

[bdovaz]

• Restore the Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions test.
• Could it be that in some file you have changed EOLs? Because I see more changes than it should.

[Thaina]

@bdovaz

• As I have mention, Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions just use Assert.Inconclusive So it should be suffice with just Warn.If
  

  UnityNuGet/src/UnityNuGet.Tests/RegistryTests.cs

  Lines 237 to 240 in ed73087

  	var versions = dependencyPackageMetas.Where(v => versionRange!.Satisfies(v.Identity.Version)).ToArray();
  	Warn.If(versions,Has.Length.GreaterThan(maxAllowedVersions));

Not only it was Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions redundantly load whole registry in exact same manner as Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Libs, it also bunching all of the lib that not pass the test into one long array. I think it would be more beneficial to separate warning into each of the testcase

• Have you use Hide WhiteSpaces already?
  

[bdovaz]

@bdovaz

• As I have mention, Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions just use Assert.Inconclusive So it should be suffice with just Warn.If
  

  UnityNuGet/src/UnityNuGet.Tests/RegistryTests.cs

  Lines 237 to 240 in ed73087

  	var versions = dependencyPackageMetas.Where(v => versionRange!.Satisfies(v.Identity.Version)).ToArray();
  	Warn.If(versions,Has.Length.GreaterThan(maxAllowedVersions));

Not only it was Ensure_Do_Not_Exceed_The_Maximum_Number_Of_Allowed_Versions redundantly load whole registry in exact same manner as Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Libs, it also bunching all of the lib that not pass the test into one long array. I think it would be more beneficial to separate warning into each of the testcase

• Have you use Hide WhiteSpaces already?
  

I agree with the test you mention.

Normally I don't touch that "Hide whitespace" checkbox because if I check it I don't see this kind of problems I mention, have you checked that you haven't changed any EOL? Because that's what it looks like.

[Thaina]

have you checked that you haven't changed any EOL?

I don't really sure, I use vscode and I don't know if it saved with difference EOL than the source or not and it also not report any change except 2 lines of code that it trimming whitespace automatically

[Thaina]

@bdovaz If the EOL was changed can you just edit that to merge the pull?