Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Support rolling adaption to Xorbits #560

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

RayJi01
Copy link
Contributor

@RayJi01 RayJi01 commented Jul 2, 2023

…g and then mean()

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.4.1 milestone Jul 2, 2023
@RayJi01 RayJi01 changed the title now will automatically execute on Xorbits's scope when calling rollin… BUG: Xorbits now will execute and fetch the result generated from the rolling.mean() command Jul 2, 2023
@XprobeBot XprobeBot added the bug Something isn't working label Jul 2, 2023
@RayJi01 RayJi01 linked an issue Jul 2, 2023 that may be closed by this pull request
@RayJi01 RayJi01 changed the title BUG: Xorbits now will execute and fetch the result generated from the rolling.mean() command BUG: Support rolling adaption to Xorbits Jul 2, 2023
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #560 (fb48c31) into main (ce105d5) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   93.66%   93.56%   -0.11%     
==========================================
  Files        1010     1010              
  Lines       78079    78094      +15     
  Branches    16207    16211       +4     
==========================================
- Hits        73131    73065      -66     
- Misses       3309     3373      +64     
- Partials     1639     1656      +17     
Flag Coverage Δ
unittests 93.47% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xorbits/core/adapter.py 97.56% <100.00%> (+<0.01%) ⬆️
python/xorbits/pandas/groupby.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.4.1, Temp Jul 10, 2023
@aresnow1 aresnow1 removed this from the Temp milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby rolling adaption
3 participants