-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Slurm Deployment For Xorbits #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengjieLi28
changed the title
Slurm Deployment For Xorbits
FEAT: Slurm Deployment For Xorbits
Sep 25, 2023
Please fix your python lint firstly. Refer https://doc.xorbits.io/en/latest/development/contributing_codebase.html#pre-commit to use |
modified: ../python/xorbits/deploy/cluster/Slurm.py modified: ../python/xorbits/deploy/cluster/slurm.sh
Codecov Report
@@ Coverage Diff @@
## main #719 +/- ##
===========================================
+ Coverage 82.55% 93.58% +11.03%
===========================================
Files 1058 1059 +1
Lines 79780 79781 +1
Branches 16504 16504
===========================================
+ Hits 65861 74663 +8802
+ Misses 11645 3443 -8202
+ Partials 2274 1675 -599
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
Signed-off-by: liddle rain <[email protected]>
ChengjieLi28
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In the past, if the user need to deploy xorbits on the slurm, they need to construct bash code by themselves. And it's so hard to debug for the slurm systems, because the output file should only output in the shared file.
So with the help from xorbits, I have constructed Class which is named Slurm, which could generate the slurm.sh and sbatch it automatically. What's more, the docker with slurm cluster test environment has been completed.
Related issue number
Fixes #315
Check code requirements