Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: read parquet from s3 error: No Such Bucket #732

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Oct 7, 2023

What do these changes do?

  • Fix a bug when reading parquet from s3
  • Fix some code spell by the way.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Oct 7, 2023
@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #732 (f44dc1d) into main (9bff550) will increase coverage by 6.96%.
Report is 1 commits behind head on main.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
+ Coverage   86.58%   93.54%   +6.96%     
==========================================
  Files        1026     1026              
  Lines       79520    79548      +28     
  Branches    16477    16488      +11     
==========================================
+ Hits        68851    74412    +5561     
+ Misses       9114     3451    -5663     
- Partials     1555     1685     +130     
Flag Coverage Δ
unittests 93.43% <96.15%> (+6.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hon/xorbits/_mars/dataframe/groupby/aggregation.py 95.48% <100.00%> (-0.41%) ⬇️
python/xorbits/_mars/dataframe/groupby/nunique.py 100.00% <100.00%> (ø)
python/xorbits/_mars/learn/linear_model/_base.py 95.37% <ø> (+69.44%) ⬆️
...n/xorbits/_mars/learn/metrics/pairwise/pairwise.py 100.00% <ø> (+54.54%) ⬆️
python/xorbits/_mars/tensor/base/tile.py 77.27% <ø> (ø)
python/xorbits/_mars/tensor/utils.py 86.98% <ø> (+1.30%) ⬆️
...xorbits/_mars/dataframe/datasource/read_parquet.py 95.52% <33.33%> (+1.26%) ⬆️

... and 110 files with indirect coverage changes

@aresnow1 aresnow1 merged commit 771858d into xorbitsai:main Oct 8, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants