-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reduction agg with numpy udf #742
Merged
ChengjieLi28
merged 10 commits into
xorbitsai:main
from
luweizheng:fix_reduction_agg_udf
Oct 16, 2023
Merged
Fix reduction agg with numpy udf #742
ChengjieLi28
merged 10 commits into
xorbitsai:main
from
luweizheng:fix_reduction_agg_udf
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
- Coverage 93.34% 88.30% -5.04%
==========================================
Files 1026 1026
Lines 79589 79589
Branches 16497 16497
==========================================
- Hits 74290 70281 -4009
- Misses 3616 7479 +3863
- Partials 1683 1829 +146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codingl2k1
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Similar issue like #737
Check code requirements