This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
More accurate calculations on non-WebKit browsers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 2, 2012 13:22
…the display area. See http://www.w3.org/TR/css3-mediaqueries/#width for more info.
…ow width on every browser except for WebKit, which includes scrollbar width in window width.
| https://github.com/brandonaaron/jquery-getscrollbarwidth/blob/master/jquery.getscrollbarwidth.js */ | ||
|
|
||
| if ( !scrollbarWidth ) { | ||
| if ( $.browser.msie ) { |
There was a problem hiding this comment.
jquery deprecated $.browser with version 1.9
Maybe we can define something like that instead of $.browser.msie:
var isMsie = /MSIE/gi.test(navigator.userAgent);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've fixed a bug that I mentioned to you on Twitter a while back. The fix now works in all major browsers.
On most browsers, the value returned by $.width() doesn't include the scrollbar width. The one exception is WebKit. Media queries do include the scrollbar width.
As a result, when you run the current version of breakpoints.js on a non-WebKit browser, the breakpoint that's detected in JS is sometimes different from the breakpoint that is actually active. (Screenshot)
To fix the problem, I'm using jquery.getscrollbarwidth to calculate the width of the scrollbar, then adding that value to the width that jQuery provides. On WebKit, I'm just accepting the width value without adding the scrollbar width.
Please let me know if you have any questions, and thanks for building this awesome script!
Best,
Ryan