QA: Inline impl into segmentFor()

xp-framework · Dec 22, 2024 · 858602e · 858602e
1 parent 5330211
commit 858602e
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/main/php/img/io/MetaDataReader.class.php b/src/main/php/img/io/MetaDataReader.class.php
@@ -44,12 +44,6 @@ class MetaDataReader {
     "\xfc" => 'JPG12', "\xfd" => 'JPG13', "\xfe" => 'COM',   
   ];
 
-  protected $impl= [
-    'SOF0'  => SOFNSegment::class,    // image width and height
-    'APP1'  => APP1Segment::class,    // Exif, XMP
-    'APP13' => APP13Segment::class,   // IPTC
-    'COM'   => CommentSegment::class
-  ];
 
   /**
    * Returns a segment
@@ -59,8 +53,15 @@ class MetaDataReader {
    * @return img.io.Segment
    */
   protected function segmentFor($marker, $data) {
+    static $impl= [
+      'SOF0'  => SOFNSegment::class,    // image width and height
+      'APP1'  => APP1Segment::class,    // Exif, XMP
+      'APP13' => APP13Segment::class,   // IPTC
+      'COM'   => CommentSegment::class
+    ];
+
     if ($seg= self::$seg[$marker] ?? null) {
-      if ($class= $this->impl[$seg] ?? null) {
+      if ($class= $impl[$seg] ?? null) {
         return $class::read($seg, $data);
       } else {
         return new Segment($seg, $data);