WIP: initial commit of Maddie's ringfinding python modules #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
===========================================
- Coverage 91.95% 73.14% -18.82%
===========================================
Files 20 22 +2
Lines 1007 1266 +259
===========================================
Hits 926 926
- Misses 81 340 +259
Continue to review full report at Codecov.
|
|
This looks awesome! Thank you very much! I'll try to give it a full review tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial commit of Maddie's ring finding code. It still needs lots of polishing and testing but we are creating this PR so that can happen. Please don't make detailed requests for changes, but more general discussions of design/architecture.