Ensure badge + link only points to master branch #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mborgerson
reviewed
May 24, 2019
mborgerson
reviewed
May 24, 2019
- Adds link to latest artifact
DiscoStarslayer
force-pushed
the
appveyor-badge-to-master
branch
from
d626bf4
to
33ebb91
Compare
JayFoxRox
reviewed
May 24, 2019
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| | Windows Build Status | | |||
| | -------------------- | | |||
| | [](https://ci.appveyor.com/project/xqemu-bot/xqemu-manager) | | |||
| | [](https://ci.appveyor.com/project/xqemu-bot/xqemu-manager?branch=master) | | |||
| | [Latest Build](https://ci.appveyor.com/api/projects/xqemu-bot/xqemu-manager/artifacts/xqemu-manager.zip?branch=master) | | |||
There was a problem hiding this comment.
Ideally this would have said something about "Download for Windows"; I'm not sure about this second row either.
Or rather, this link should be on our website instead. GitHub is not to be used by Users, so there's no point in distributing end-user binaries here. Also see xqemu/xqemu.com#18
Anyhow, the important thing is that the links point to the right thing.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick change so users download the latest build from
master. Prevents people from thinking the project is broken thanks to bad PR's, and ensures only accepted changes get shipped to people as binaries.Also adds a clearer link to the latest artifact from the master branch.
Closes #45