Merge bitcoin#30308: QA: Expect PACKAGE_NAME rather than constant "Bi…

…tcoin Core"

197b540 QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core" (Luke Dashjr)

Pull request description:

  Followup to bitcoin#29144

ACKs for top commit:
  kevkevinpal:
    ACK [197b540](bitcoin@197b540)
  tdb3:
    ACK 197b540

Tree-SHA512: 6a2c7f7da56effa7e3eba1d103b1b4442d74a21f2ba588564cddd6d61a46c3721bf0942d4ac947ecbbbfe476501ab7b03a8414d7d0840ce9106b056811583010

test/functional/feature_settings.py

@@ -25,7 +25,7 @@ def run_test(self):
 
         # Assert default settings file was created
         self.stop_node(0)
-        default_settings = {"_warning_": "This file is automatically generated and updated by Bitcoin Core. Please do not edit this file while the node is running, as any changes might be ignored or overwritten."}
+        default_settings = {"_warning_": f"This file is automatically generated and updated by {self.config['environment']['PACKAGE_NAME']}. Please do not edit this file while the node is running, as any changes might be ignored or overwritten."}
         with settings.open() as fp:
             assert_equal(json.load(fp), default_settings)