Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Image is imported from both Rive and Flutter. #111

Merged
merged 1 commit into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Upcoming

- Fix `Image` is imported from both packages. [#110](https://github.com/xsahil03x/giffy_dialog/issues/110)

## 2.1.0

- Bump rive version to ^0.13.0.
Expand Down
12 changes: 8 additions & 4 deletions example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@ import 'package:flutter/material.dart';
import 'package:giffy_dialog/giffy_dialog.dart';
import 'package:google_fonts/google_fonts.dart';

void main() => runApp(new MyApp());
void main() => runApp(MyApp());

final material3Notifier = ValueNotifier<bool>(true);

class MyApp extends StatelessWidget {
const MyApp({super.key});

@override
Widget build(BuildContext context) {
return ValueListenableBuilder<bool>(
Expand Down Expand Up @@ -35,6 +37,8 @@ class MyApp extends StatelessWidget {
}

class MyHomePage extends StatelessWidget {
const MyHomePage({super.key});

@override
Widget build(BuildContext context) {
return Scaffold(
Expand Down Expand Up @@ -67,7 +71,7 @@ class MyHomePage extends StatelessWidget {
}

class MaterialToggleButtons extends StatelessWidget {
const MaterialToggleButtons({Key? key}) : super(key: key);
const MaterialToggleButtons({super.key});

@override
Widget build(BuildContext context) {
Expand All @@ -87,7 +91,6 @@ class MaterialToggleButtons extends StatelessWidget {

return ToggleButtons(
isSelected: [!useMaterial3, useMaterial3],
children: [Text('Material 2'), Text('Material 3')],
borderRadius: borderRadius,
borderColor: borderColor,
selectedBorderColor: borderColor,
Expand All @@ -101,6 +104,7 @@ class MaterialToggleButtons extends StatelessWidget {
onPressed: (index) {
material3Notifier.value = index == 1;
},
children: [Text('Material 2'), Text('Material 3')],
);
}
}
Expand Down Expand Up @@ -216,7 +220,7 @@ class TypedExample extends StatelessWidget {
);
}

return Container(
return SizedBox(
height: 36,
child: Row(
children: [
Expand Down
4 changes: 2 additions & 2 deletions example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ publish_to: 'none'
version: 1.0.0+1

environment:
sdk: ">=3.2.0 <4.0.0"
sdk: ^3.2.0
flutter: ">=3.16.0"

dependencies:
flutter:
sdk: flutter
giffy_dialog:
path: ../
google_fonts: ^4.0.3
google_fonts: ^6.2.0

flutter:
uses-material-design: true
2 changes: 1 addition & 1 deletion lib/giffy_dialog.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
library giffy_dialog;
library;

export 'package:lottie/lottie.dart';
export 'package:rive/rive.dart';
Expand Down
2 changes: 1 addition & 1 deletion lib/src/giffy_modal.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:lottie/lottie.dart';
import 'package:rive/rive.dart';
import 'package:rive/rive.dart' hide Image;

import 'entry_animation.dart';

Expand Down
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,19 @@ repository: https://github.com/xsahil03x/giffy_dialog
issue_tracker: https://github.com/xsahil03x/giffy_dialog/issues

environment:
sdk: ">=3.2.0 <4.0.0"
sdk: ^3.2.0
flutter: ">=3.16.0"

dependencies:
flutter:
sdk: flutter
rive: ^0.13.0
lottie: ^3.0.0
lottie: ^3.1.0

dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^3.0.0
flutter_lints: ">=4.0.0 <6.0.0"

topics:
- dialog
Expand Down