Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor index #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor index #409

wants to merge 1 commit into from

Conversation

xtuc
Copy link
Owner

@xtuc xtuc commented Jul 7, 2018

Attempt to fix #405

The idea is to transform our Index that has either Identifier or NumerLiteral to a structure that contains both (the Identifier is optional tho).

Notes:

  • The naming is awful (indexOfIndex), any idea?
  • The tests are massively failing

@ColinEberhardt
Copy link
Collaborator

ColinEberhardt commented Jul 7, 2018

For the naming, it might be worth using the terminology from the specification:

image

They refer to identifiers as being either numeric or symbolic.

This suggests to me something like the following:

{
   type: "identifier",
   symbolic: "log",
   numeric: 23
}

Or the more verbose:

{
   type: "identifier",
   symbolicIdentifier: "log",
   numericIdentifier: 23
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm-edit -- Valid edits can throw with default decode options.
2 participants