Update GlossarySheet.xml #3
Conversation
some Code fixes ($object.getPropertyReference())
| @@ -52,7 +52,7 @@ | |||
| <dl> | |||
| <dt #if (!$editing && $hasEdit) | |||
| class="editableProperty" | |||
| data-property="$escapetool.xml($services.model.serialize($object.getProperty('title').reference))" | |||
| data-property="$escapetool.xml($services.model.serialize($object.getPropertyReference('title')))" | |||
There was a problem hiding this comment.
Note that this causes the glossary application to depends on 12.10.11 (it currently only requires 12.10). I guess it's acceptable, but I'm not really in charge of this application, so I prefer letting someone else decide.
There was a problem hiding this comment.
Indeed, it's weird that a new API was added in a bugfix release but it's the case : https://github.com/xwiki/xwiki-platform/blob/78f0a96fbe41e7f5c6242b1386bf1e7255dd1e1e/xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Object.java#L142
@jmiba Does it mean that the xobject doesn't have the "title" property set in some circumstances? That seems weird since that property comes from the GlossaryClass XClass so it should always be there from what I see.
| <comment/> | ||
| <minorEdit>false</minorEdit> | ||
| <syntaxId>xwiki/2.1</syntaxId> | ||
| <hidden>true</hidden> |
There was a problem hiding this comment.
I can't see what's changed above. Maybe new lines?
|
@jmiba Thanks a lot. Would you mind creating a jira issue at https://jira.xwiki.org/projects/GLOSSARY/summary explaining the bug and setting the affected version of the glossary app? Then, if you could rebase your commit to include a reference to the jira that would be awesome (see https://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices#HRule:AlwaysputaJIRAissuereferenceincommitmessages ). Thanks again. |
some Code fixes ($object.getPropertyReference())