CRISTAL-257: The edit button is presented even if the current user does not have edit rights #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es not have edit rights
manuelleduc
reviewed
Dec 23, 2024
manuelleduc
reviewed
Dec 23, 2024
manuelleduc
reviewed
Dec 23, 2024
…es not have edit rights * Hide edit button when edition is disabled * Improve comments
…es not have edit rights * Add missing comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/CRISTAL-257
Changes
Description
Clarifications
The changes in this PR are only related to the XWiki backend.
Screenshots & Video
Executed Tests
The test suite was run fully, and the new feature was tested with multiple rights combinations.
Expected merging strategy