XWIKI-22121: Improve the registration experience (#3627)

* Improved maintanibility reported by SonarCloud * Fixed a typo in Registration.xml
xwiki · Nov 7, 2024 · d7541b6 · d7541b6
1 parent 35425fd
commit d7541b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml b/...administration/xwiki-platform-administration-ui/src/main/resources/XWiki/Registration.xml
@@ -284,7 +284,7 @@
     ## Also, not filled back in if there is an error ('noReturn').
     #set($field =
       {'name' : 'captcha_placeholder',
-        'label' : $services.localization.render('core.captcha.label')
+        'label' : $services.localization.render('core.captcha.label'),
         'skipLabelFor' : true,
         'type'  : 'html',
         'html'  : "&lt;span class='xHint'&gt;$escapetool.xml($services.localization.render('core.captcha.instruction'))

diff --git a/...war/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation_prototype.js b/...war/src/main/webapp/resources/uicomponents/widgets/validation/livevalidation_prototype.js
@@ -457,8 +457,8 @@ LiveValidation.prototype = {
    *	Empties out the message elements if they exist
    */
   removeMessage: function(){
-    for (let i = 0; i < this.validations.length; i++) {
-      let messageHolder = this.validations[i].messageHolder;
+    for (let validation of validations) {
+      let messageHolder = validation.messageHolder;
       this.removeMessageClass(messageHolder);
       messageHolder.lastChild.textContent = '';
     }