Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-19751: Move the "watch" button for a page to the page content menu #3059

Merged
merged 29 commits into from
Jun 12, 2024
Merged

XWIKI-19751: Move the "watch" button for a page to the page content menu #3059

merged 29 commits into from
Jun 12, 2024

Commits on Jun 11, 2024

  1. XWIKI-19751: Move the "watch" button for a page to the page content menu 

    Work in progress: remove UI code for watch switch buttons, and start
introducing a new UIX for the watch button next to the edit button.
Start refactoring API for computing if a page is watched or not to get
all info.
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    80bc90b View commit details
    Browse the repository at this point in the history

  2. XWIKI-19751: Move the "watch" button for a page to the page content menu

    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    451e72d View commit details
    Browse the repository at this point in the history

  3. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix some tests in notification filters
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cc069a1 View commit details
    Browse the repository at this point in the history

  4. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Start providing REST API for watch pages to simplify operations
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    72492dc View commit details
    Browse the repository at this point in the history

  5. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Distinguish more cases for watched / ignored pages to improve UI
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    dfd99a4 View commit details
    Browse the repository at this point in the history

  6. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Provide implementation for REST API for watching pages
  * Improve WatchEntitiesManager API to support more operations
  * Improve WatchedEntityReference API to use UserReference
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9db5cac View commit details
    Browse the repository at this point in the history

  7. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Provide a dedicated page to handle watch settings
  * Start writing javascript code to handle choices
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    40fda2f View commit details
    Browse the repository at this point in the history

  8. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix issue in WatchedEntitiesManager
  * Start providing doc / fixing checkstyle
  * Handle a bit more actions in UI
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    db7bbb5 View commit details
    Browse the repository at this point in the history

  9. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix a bug in state computer related to the fact that the scoe filter
    hierarchy is not really a hierarchy
  * Provide a new API to allow computing the reference of the immediate
    ancestor of a page for which a filter exists
  * Improve UI to base possible actions on multiple criteria: current
    watch status, presence or not of a filter on an ancestor, and check
if the page is terminal or not
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    09eca34 View commit details
    Browse the repository at this point in the history

  10. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Encode all options for the watch settings modal
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e11958b View commit details
    Browse the repository at this point in the history

  11. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Change the URL scheme for the REST API
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5cc137d View commit details
    Browse the repository at this point in the history

  12. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Minor improvments
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1ca3adf View commit details
    Browse the repository at this point in the history

  13. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Provide test for notification rest module
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    87c6fde View commit details
    Browse the repository at this point in the history

  14. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix checkstyle
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    427aea2 View commit details
    Browse the repository at this point in the history

  15. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Put revapi ignores
  * Start fixing since
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b09f609 View commit details
    Browse the repository at this point in the history

  16. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Provide translations and improve UIX code
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c9220f2 View commit details
    Browse the repository at this point in the history

  17. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Provide page object and fix integration tests
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7c9d908 View commit details
    Browse the repository at this point in the history

  18. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Ensure to not display the watch status for guest
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    40d3b8a View commit details
    Browse the repository at this point in the history

  19. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix a few since and some problems in UIX
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    448efaa View commit details
    Browse the repository at this point in the history

  20. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix API of WatchedUserReference
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    25a6a41 View commit details
    Browse the repository at this point in the history

  21. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix bad escaping
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    85a6061 View commit details
    Browse the repository at this point in the history

  22. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Better exception handling for creating references
  * Various improvments in translations (active voice + use of ignore)
  * Improve a bit the UI
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8256074 View commit details
    Browse the repository at this point in the history

  23. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Improve UI when a page is ignored/followed by an ancestor and check
    proper rights
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    92edb7c View commit details
    Browse the repository at this point in the history

  24. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Review available options and improve javascript to allow chaining
    operations: following space when the page is followed implies to
first unfollow the page to not keep unnecessary filters and mess up the
UI
  * Improve translations
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    227a24d View commit details
    Browse the repository at this point in the history

  25. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Clean up some unnecessary code
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    89efc19 View commit details
    Browse the repository at this point in the history

  26. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Make the UI a bit more clear
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8b1754a View commit details
    Browse the repository at this point in the history

  27. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix some stuff after rebsae
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    314e20a View commit details
    Browse the repository at this point in the history

  28. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Slightly improve UX
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    390cb98 View commit details
    Browse the repository at this point in the history

  29. XWIKI-19751: Move the "watch" button for a page to the page content menu 

      * Fix missing unstable
  * Fix bad deprecated API call
    @surli
    surli committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6cbee52 View commit details
    Browse the repository at this point in the history