Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22165: Home page icons do not have a text alternative #3123

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

XWIKI-22165: Home page icons do not have a text alternative #3123

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9fc3b59
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 May 17, 2024
fb87604
Merge branch 'xwiki:master' into XWIKI-22165
Sereza7 May 24, 2024
f1b8e50
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 May 24, 2024
10f576c
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 Sep 6, 2024
df42d34
Merge branch 'master' into XWIKI-22165
Sereza7 Sep 6, 2024
2f71bec
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 Sep 11, 2024
a0815ef
Merge branch 'xwiki:master' into XWIKI-22165
Sereza7 Sep 11, 2024
7d12a73
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 Sep 11, 2024
6ae4ff0
Merge branch 'xwiki:master' into XWIKI-22165
Sereza7 Nov 27, 2024
51edb3b
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 Nov 27, 2024
ac286c2
XWIKI-22165: Home page icons do not have a text alternative
Sereza7 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...tion-flavor/xwiki-platform-distribution-flavor-common/src/main/resources/Main/WebHome.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,13 @@ XWiki can be used as a knowledge base (support, documentation, sales, etc.), for

To make the most out of your wiki, log-in and:

Use the {{displayIcon name="pencil"/}} button above to //edit// this page and start customizing your wiki to your needs.
Use the {{displayIcon name="pencil"/}}{{html}}<span class="sr-only">Edit</span>{{/html}} button above to //edit// this page and start customizing your wiki to your needs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be better to actually improve the displayIcon macro to be able to insert the alternative text?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I'm not a big fan of inserting an {{html}} macro there: it makes the page content more complex.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to use HTML, using (% class="sr-only" %)Edit(% %) should give the exactly same HTML but has the disadvantage that it isn't editable in the WYSIWYG editor. I agree with @surli that it might be better to integrate this as a macro parameter to make it easier to discover.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Simon, it's very important that the home page be as simple as possible to edit/understand as it's made to be edited and modified. It also acts as example. So -1 from me too to add the html macro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in f1b8e50 👍


Use the {{displayIcon name="add"/}} button above to //add// more pages to your wiki and create the //hierarchy// that best organizes your content.
Use the {{displayIcon name="add"/}}{{html}}<span class="sr-only">Create</span>{{/html}} button above to //add// more pages to your wiki and create the //hierarchy// that best organizes your content.

Use the {{displayIcon name="home"/}} breadcrumbs located above the title to //navigate// inside your pages. It's easy to get lost in a big wiki without them.
Use the {{displayIcon name="home"/}}{{html}}<span class="sr-only">Home</span>{{/html}} breadcrumbs located above the title to //navigate// inside your pages. It's easy to get lost in a big wiki without them.

{{html}}<p class="sr-only">Those three buttons are accessible using a keyboard between the global navbar elements and the main page content.</p>{{/html}}

You can also use the [[Sandbox>>Sandbox.WebHome]] for more demo content and generally a place to experiment with your wiki's features.

Expand Down