Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21878: Various close button modals do not use intended icons #3371

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Aug 27, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21878

Changes

Description

  • Reduced line length to match quality requirement imposed by eslint.

Clarifications

The build was failing with
11:53:11,890 [INFO] /root/workspace/XWiki_xwiki-platform_master/xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar/target/vue/utilities/XWikiIcon.vue 11:53:11,890 [INFO] 89:1 error This line has a length of 130. Maximum allowed is 120 max-len
This PR goal is to fix this regression introduced in #2888.

Executed Tests

Successfully ran the quality build that was failing:
mvn clean install -f xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar -Pquality

Expected merging strategy

* Reduced line length to match quality requirement imposed by eslint.
@surli surli merged commit 2683f12 into xwiki:master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants