Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-22636: The navigation panel information box icon is smaller than expected #3668

Merged
merged 1 commit into from
Nov 21, 2024
Merged

XWIKI-22636: The navigation panel information box icon is smaller than expected #3668

merged 1 commit into from
Nov 21, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Nov 21, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22636

Changes

Description

  • Fixed style for block Silk icons.

Clarifications

  • The structure was changed in a fix for XWIKI-21452 and not tested as well as it was initially. This code responsible for styling of Silk icons in block macros wasn't updated and was useless. I updated it and fixed the issue mentionned in the ticket.

Screenshots & Video

Before the changes proposed in this PR:
Screenshot from 2024-11-21 14-35-47
image
After the changes proposed in this PR:
Screenshot from 2024-11-21 14-39-33
Screenshot from 2024-11-21 14-39-52

Executed Tests

Manual tests, see screenshots above.
Didn't execute any automated test since this is a style bug only that was reported only thanks to human observation.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.X

@Sereza7
XWIKI-22636: The navigation panel information box icon is smaller tha…
a091742 
…n expected

* Fixed style for block Silk icons.
@michitux michitux merged commit 5b1910d into xwiki:master Nov 21, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@Sereza7 @github-actions
XWIKI-22636: The navigation panel information box icon is smaller tha…
e1b2ece 
…n expected (#3668)

* Fixed style for block Silk icons.

(cherry picked from commit 5b1910d)
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
michitux pushed a commit that referenced this pull request Nov 21, 2024
@Sereza7 @michitux
XWIKI-22636: The navigation panel information box icon is smaller tha…
4fb3ccd 
…n expected (#3668)

* Fixed style for block Silk icons.

(cherry picked from commit 5b1910d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michitux michitux

Labels
backport stable-16.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sereza7 @michitux