XWiki export doesn't work properly when a diagram is present. #311 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as#311 * Updated the view sheet and macro to make the xwiki export work properly.
oanalavinia
requested changes
Nov 20, 2024
application-diagram-ui/src/main/resources/Diagram/DiagramMacro.xml
Outdated
Show resolved
Hide resolved
application-diagram-ui/src/main/resources/Diagram/DiagramViewSheet.xml
Outdated
Show resolved
Hide resolved
application-diagram-ui/src/main/resources/Diagram/DiagramViewSheet.xml
Outdated
Show resolved
Hide resolved
application-diagram-ui/src/main/resources/Diagram/DiagramViewSheet.xml
Outdated
Show resolved
Hide resolved
application-diagram-ui/src/main/resources/Diagram/DiagramViewSheet.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve this issue properly, I had to address both the diagram macro and the normal diagram page. In the case of the diagram macro, the fix was pretty straightforward: replacing the view of the diagram from a div to the actual SVG. I had to keep the div to avoid errors in the console when exporting the PDF. To make the diagram macro work, we had to do the same thing, in addition I also had to get the right document.