Fix: 购物车为空的时候, 是否在购物车中的判断出错

xxxXXX95 · Jan 29, 2021 · 10bda0e · 10bda0e
1 parent 3da77bf
commit 10bda0e
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/__tests__/jobs.test.js b/__tests__/jobs.test.js
@@ -65,4 +65,27 @@ describe('isSkuInCart', function () {
     const res5 = await isSkuInCart('5');
     expect([res1, res2, res3, res4, res5]).toEqual([[], [], [], ['4'], []]);
   });
+
+  test('if cart is empty should return all skuIds', async () => {
+    fetch.mockImplementation(() => {
+      return Promise.resolve({
+        headers: {
+          raw: () => {
+            return {};
+          },
+        },
+        json() {
+          return {
+            success: true,
+            resultData: {
+              cartInfo: null,
+            },
+          };
+        },
+      });
+    });
+    const res1 = await isSkuInCart('1');
+    const res2 = await isSkuInCart(['1', '2', '3']);
+    expect([res1, res2, ]).toEqual([['1'], ['1', '2', '3']]);
+  });
 });
diff --git a/jobs.js b/jobs.js
@@ -273,7 +273,7 @@ async function isSkuInCart(skuId, areaId) {
   if (res.success) {
     let allskus = [];
     const allIds = new Set();
-    if (!res.resultData.cartInfo) return false;
+    if (!res.resultData.cartInfo) return skuIds;
     res.resultData.cartInfo.vendors.forEach(v => {
       allskus = allskus.concat(v.sorted);
     });
@@ -288,7 +288,7 @@ async function isSkuInCart(skuId, areaId) {
     });
     return skuIds.filter(s => !allIds.has(s));
   }
-  return [];
+  return skuIds;
 }
 
 /**