Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce pyproject.toml + pdm #348

Closed
wants to merge 15 commits into from
Closed

Introduce pyproject.toml + pdm #348

wants to merge 15 commits into from

Conversation

stankudrow
Copy link

@stankudrow stankudrow commented Nov 5, 2024 •
edited
Loading

Fixes #345 .

A variation of #346 .

Checklist:

  • Add tests that demonstrate the correct behaviour of the change. Tests should fail without the change. -> NO NEED TO.
  • Add or update relevant docs, in the docs folder and in code. -> NO NEED TO
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues. -> WITH RUFF
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html. -> DONE UNDER PY3.9

@stankudrow stankudrow marked this pull request as draft November 5, 2024 17:23
@stankudrow stankudrow changed the title Introduce pyproject.toml_pdm Introduce pyproject.toml + pdm Nov 5, 2024
@stankudrow
Copy link
Author

@xzkostyan , @DaniilAnichin, let's give this PR a try in favour of #346 .

@stankudrow stankudrow marked this pull request as ready for review November 5, 2024 18:11
@stankudrow stankudrow mentioned this pull request Nov 5, 2024
Closed
5 tasks
stankudrow
stankudrow commented Nov 9, 2024
View reviewed changes
testsrequire.py
Comment on lines -3 to +9
'pytest',
'pytest-asyncio',
'sqlalchemy>=2.0.0,<2.1.0',
'greenlet>=2.0.1',
'alembic',
'requests',
'responses',
'parameterized'
"pytest",
"pytest-asyncio",
"sqlalchemy>=2.0.0,<2.1.0",
"greenlet>=2.0.1",
"alembic",
"requests",
"responses",
"parameterized",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe getting rid of this file and just launching pytest?

dolfinus
dolfinus reviewed Nov 9, 2024
View reviewed changes
@stankudrow stankudrow requested a review from dolfinus November 9, 2024 17:05
@dolfinus
Copy link

Sorry, but I'm not related to this project at all, and have no permissions to approve this PR. Could you please remove me from reviewers?

@stankudrow
Copy link
Author

stankudrow commented Nov 11, 2024 •
edited
Loading

Sorry, but I'm not related to this project at all, and have no permissions to approve this PR. Could you please remove me from reviewers?

Hm, I cannot or I don't see the option.

But you can share your opinion about this PR anyway, I'll be glad.

@stankudrow
Copy link
Author

@xzkostyan , hello, sorry for pinging. Could you assign a reviewer for this PR and name some maintainers to tag for not disturbing you?

@stankudrow
Copy link
Author

@xzkostyan , hello. Could you possibly have a look at this PR?

@stankudrow stankudrow marked this pull request as draft December 21, 2024 11:46
@stankudrow
Copy link
Author

What is moving this project to uv 🤔 .

@stankudrow stankudrow closed this Dec 24, 2024
@stankudrow stankudrow deleted the introduce-pdm branch December 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus Awaiting requested review from dolfinus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pyproject.toml project metadata file backended with building/packaging/dependency manager.
2 participants
@stankudrow @dolfinus