Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pyproject.toml + poetry #346

Closed
wants to merge 14 commits into from

Conversation

stankudrow
Copy link

@stankudrow stankudrow commented Oct 30, 2024

Addresses the issue #345

Checklist:

  • Add tests that demonstrate the correct behaviour of the change. Tests should fail without the change. - no need to
  • Add or update relevant docs, in the docs folder and in code. - no need to
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.

References:

@stankudrow stankudrow marked this pull request as draft October 30, 2024 19:31
Copy link

@DaniilAnichin DaniilAnichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted required changes on entry-points; and we either need to put versions back in __init__.py, or to change the documentation to avoid error on the import.
The rest is more or less the question of taste

@stankudrow stankudrow marked this pull request as ready for review November 1, 2024 20:28
Copy link

@DaniilAnichin DaniilAnichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks ok, I guess

@stankudrow stankudrow mentioned this pull request Nov 5, 2024
5 tasks
@stankudrow
Copy link
Author

Would like to favour the PR #348 instead of this one.

@stankudrow stankudrow marked this pull request as draft November 6, 2024 13:45
@stankudrow stankudrow closed this Nov 9, 2024
@stankudrow stankudrow deleted the introduce-poetry branch December 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants