Skip to content

Commit

Permalink
Error messages - Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: kirkrodrigues <[email protected]>
  • Loading branch information
junhaoliao and kirkrodrigues authored Nov 7, 2024
1 parent b940296 commit 1087f94
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/clp_ffi_js/ir/StructuredIrStreamReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ auto StructuredIrStreamReader::deserialize_stream() -> size_t {
__FILENAME__,
__LINE__,
std::format(
"Failed to deserialize: {}:{}",
"Failed to deserialize IR unit: {}:{}",
error.category().name(),
error.message()
)
Expand Down Expand Up @@ -148,7 +148,7 @@ auto StructuredIrStreamReader::decode_range(size_t begin_idx, size_t end_idx, bo

auto const json{log_event.serialize_to_json()};
if (false == json.has_value()) {
SPDLOG_ERROR("Failed to decode message.");
SPDLOG_ERROR("Failed to decode log event.");
break;
}

Expand Down
2 changes: 1 addition & 1 deletion src/clp_ffi_js/ir/StructuredIrStreamReader.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class IrUnitHandler {
[[maybe_unused]] clp::UtcOffset utc_offset_old,
[[maybe_unused]] clp::UtcOffset utc_offset_new
) -> clp::ffi::ir_stream::IRErrorCode {
SPDLOG_WARN("UTC offset change packets are currently not handled.");
SPDLOG_WARN("UTC offset change packets aren't handled currently.");

return clp::ffi::ir_stream::IRErrorCode::IRErrorCode_Success;
}
Expand Down

0 comments on commit 1087f94

Please sign in to comment.