Apply suggestions from code review

Co-authored-by: kirkrodrigues <[email protected]>
y-scope · Oct 10, 2024 · bd29b8f · bd29b8f
1 parent 7d01cf2
commit bd29b8f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/clp_ffi_js/ir/StreamReader.cpp b/src/clp_ffi_js/ir/StreamReader.cpp
@@ -114,10 +114,14 @@ void StreamReader::filter_log_events(emscripten::val const& log_level_filter) {
     }
 
     m_filtered_log_event_map.emplace();
-    auto filter_levels{emscripten::vecFromJSArray<std::uint8_t>(log_level_filter)};
+    auto filter_levels{emscripten::vecFromJSArray<std::underlying_type_t<LogLevel>>(log_level_filter
+    )};
     for (size_t log_event_idx = 0; log_event_idx < m_encoded_log_events.size(); ++log_event_idx) {
         auto const& log_event = m_encoded_log_events[log_event_idx];
-        if (std::ranges::find(filter_levels, static_cast<std::uint8_t>(log_event.get_log_level()))
+        if (std::ranges::find(
+                    filter_levels,
+                    clp::enum_to_underlying_type(log_event.get_log_level())
+            )
             != filter_levels.end())
         {
             m_filtered_log_event_map->emplace_back(log_event_idx);