Skip to content

Commit

Permalink
Nest anonymous namespace into clp_ffi_js::ir to reduce scope of const…
Browse files Browse the repository at this point in the history
… strings with internal linkage - Apply suggestions from code review

Co-authored-by: kirkrodrigues <[email protected]>
  • Loading branch information
junhaoliao and kirkrodrigues authored Nov 8, 2024
1 parent 81135fa commit cca920a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/clp_ffi_js/ir/StructuredIrStreamReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <clp_ffi_js/ir/StreamReader.hpp>
#include <clp_ffi_js/ir/StreamReaderDataContext.hpp>

namespace clp_ffi_js::ir {
namespace {
constexpr std::string_view cEmptyJsonStr{"{}"};
constexpr std::string_view cLogLevelFilteringNotSupportedErrorMsg{
Expand All @@ -33,7 +34,6 @@ constexpr std::string_view cLogLevelFilteringNotSupportedErrorMsg{
constexpr std::string_view cReaderOptionsTimestampKey{"timestampKey"};
} // namespace

namespace clp_ffi_js::ir {
using clp::ir::four_byte_encoded_variable_t;

auto StructuredIrStreamReader::create(
Expand Down

0 comments on commit cca920a

Please sign in to comment.