-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor StreamReaderDataContext
to encapsulate readers instead of zstd decompressors; Change its template type to deserializer.
#24
Closed
junhaoliao
wants to merge
6
commits into
y-scope:main
from
junhaoliao:StreamReaderDataContext-take-deserializer
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2d59807
Change template type to deserializer in `StreamReaderDataContext`.
junhaoliao 3b90f9d
Use ReaderInterface instead of zstd decompressor in StreamReaderDataC…
junhaoliao 6923a73
Expose the reader in StreamReaderDataContext via a new method get_rea…
junhaoliao 7d4e78e
Reorder include directives in `StreamReader.hpp`.
junhaoliao 0aafca0
Add "IR" into docstrings - Apply suggestions from code review
junhaoliao b6dec2f
Move `using` into namespaces.
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,13 +6,16 @@ | |
#include <optional> | ||
#include <vector> | ||
|
||
#include <clp/ir/LogEventDeserializer.hpp> | ||
#include <clp/ir/types.hpp> | ||
#include <clp/TimestampPattern.hpp> | ||
#include <emscripten/bind.h> | ||
#include <emscripten/val.h> | ||
|
||
#include <clp_ffi_js/ir/LogEventWithLevel.hpp> | ||
#include <clp_ffi_js/ir/StreamReaderDataContext.hpp> | ||
using clp::ir::four_byte_encoded_variable_t; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
||
using clp::ir::LogEventDeserializer; | ||
|
||
namespace clp_ffi_js::ir { | ||
EMSCRIPTEN_DECLARE_VAL_TYPE(DataArrayTsType); | ||
|
@@ -97,12 +100,14 @@ class StreamReader { | |
|
||
private: | ||
// Constructor | ||
explicit StreamReader(StreamReaderDataContext<clp::ir::four_byte_encoded_variable_t>&& | ||
stream_reader_data_context); | ||
explicit StreamReader( | ||
StreamReaderDataContext<LogEventDeserializer<four_byte_encoded_variable_t>>&& | ||
stream_reader_data_context | ||
); | ||
|
||
// Variables | ||
std::vector<LogEventWithLevel<clp::ir::four_byte_encoded_variable_t>> m_encoded_log_events; | ||
std::unique_ptr<StreamReaderDataContext<clp::ir::four_byte_encoded_variable_t>> | ||
std::vector<LogEventWithLevel<four_byte_encoded_variable_t>> m_encoded_log_events; | ||
std::unique_ptr<StreamReaderDataContext<LogEventDeserializer<four_byte_encoded_variable_t>>> | ||
m_stream_reader_data_context; | ||
FilteredLogEventsMap m_filtered_log_event_map; | ||
clp::TimestampPattern m_ts_pattern; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this into namespace per kirk suggestion in last pr.